dawy_go/vnote
1
0
Fork 0
mirror of https://gitee.com/vnotex/vnote.git synced 2025-07-05 13:59:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

VSearchEngine: avoid virtual func in detor (#570)

Browse Source 
Clang-tidy checker warns followings.

Call to virtual function during destruction
[clang-analyzer-optin.cplusplus.VirtualCall]
  stop();
  clear();
note: This destructor of an object of type '~VSearchEngine'
has not returned when the virtual method was called

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
This commit is contained in:
Hiroshi Miura 2019-01-13 11:55:20 +09:00 committed by Le Tan
parent e8b2530ca3
commit 3c9c121d91
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/vsearchengine.cpp
View File

@ -151,8 +151,14 @@ VSearchEngine::VSearchEngine(QObject *p_parent)
VSearchEngine::~VSearchEngine() VSearchEngine::~VSearchEngine()
{ {
stop(); for (auto const & th : m_workers) {
clear(); th->stop();
th->quit();
th->wait();
delete th;
}
m_workers.clear();
m_result.clear();
} }
void VSearchEngine::search(const QSharedPointer<VSearchConfig> &p_config, void VSearchEngine::search(const QSharedPointer<VSearchConfig> &p_config,