From 6d24f7e92bb2554d3ad2ae9b1a9b68714a64b5ac Mon Sep 17 00:00:00 2001 From: Le Tan Date: Tue, 13 Feb 2018 22:18:38 +0800 Subject: [PATCH] bug-fix: remove unnecessary NULL check before delete --- src/dialog/vinsertimagedialog.cpp | 12 ++++-------- src/vtextedit.cpp | 4 +--- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/dialog/vinsertimagedialog.cpp b/src/dialog/vinsertimagedialog.cpp index 86d6a424..cd9b7c83 100644 --- a/src/dialog/vinsertimagedialog.cpp +++ b/src/dialog/vinsertimagedialog.cpp @@ -54,10 +54,8 @@ VInsertImageDialog::VInsertImageDialog(const QString &p_title, VInsertImageDialog::~VInsertImageDialog() { - if (m_image) { - delete m_image; - m_image = NULL; - } + delete m_image; + m_image = NULL; } void VInsertImageDialog::setupUI(const QString &p_title, @@ -152,10 +150,8 @@ void VInsertImageDialog::setImage(const QImage &image) { if (image.isNull()) { imagePreviewLabel->setVisible(false); - if (m_image) { - delete m_image; - m_image = NULL; - } + delete m_image; + m_image = NULL; handleInputChanged(); return; diff --git a/src/vtextedit.cpp b/src/vtextedit.cpp index 68b6595a..e784e8c9 100644 --- a/src/vtextedit.cpp +++ b/src/vtextedit.cpp @@ -36,9 +36,7 @@ VTextEdit::VTextEdit(const QString &p_text, QWidget *p_parent) VTextEdit::~VTextEdit() { - if (m_imageMgr) { - delete m_imageMgr; - } + delete m_imageMgr; } void VTextEdit::init()